Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1129#discussion_r171314892
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortConfig.java
 ---
    @@ -71,8 +72,8 @@
     
       private final int mSortBatchSize;
     
    -  public SortConfig(DrillConfig config) {
    -
    +  public SortConfig(FragmentContext context) {
    +    DrillConfig config = context.getConfig();
    --- End diff --
    
    Suggestion: pass in the original `DrillConfig` plus an option manager 
rather than the fragment context. The suggestion minimizes undesired 
dependencies.


---

Reply via email to