Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1177#discussion_r176608901
  
    --- Diff: exec/java-exec/pom.xml ---
    @@ -828,31 +828,9 @@
               </execution>
             </executions>
           </plugin>
    -      <plugin> <!-- classpath scanning  -->
    +      <plugin>
             <groupId>org.codehaus.mojo</groupId>
             <artifactId>exec-maven-plugin</artifactId>
    -        <version>1.2.1</version>
    -        <dependencies>
    -          <dependency>
    -            <groupId>org.apache.drill</groupId>
    -            <artifactId>drill-common</artifactId>
    -            <version>${project.version}</version>
    -            <classifier>tests</classifier>
    -          </dependency>
    -        </dependencies>
    -        <executions>
    -          <execution>
    -            <phase>process-classes</phase>
    -            <goals><goal>java</goal></goals>
    -          </execution>
    -        </executions>
    -        <configuration>
    -          
<mainClass>org.apache.drill.common.scanner.BuildTimeScan</mainClass>
    -          <includePluginDependencies>true</includePluginDependencies>
    --- End diff --
    
    This is a nice move. 
    I asked about `<includePluginDependencies>`, but you have already answered 
above, we just use project dependencies for now.


---

Reply via email to