Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1170#discussion_r178222960
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java
 ---
    @@ -60,13 +60,7 @@ public LimitRecordBatch(Limit popConfig, FragmentContext 
context, RecordBatch in
       protected boolean setupNewSchema() throws SchemaChangeException {
         container.zeroVectors();
         transfers.clear();
    -
    -
    -    for(final VectorWrapper<?> v : incoming) {
    -      final TransferPair pair = v.getValueVector().makeTransferPair(
    -          container.addOrGet(v.getField(), callBack));
    -      transfers.add(pair);
    -    }
    +    container.onSchemaChange(incoming, callBack, transfers);
    --- End diff --
    
    `onSchemaChange()` may perhaps be the wrong name. It is why this 
functionality is called in this case. But, the actual functionality is closer 
to `setupTransfers()` (assuming the removed code was simply moved into the 
container class...)


---

Reply via email to