GitHub user ChrisSandison opened a pull request:
https://github.com/apache/drill/pull/1201
DRILL-4091: Support for additional gis operations in gis contrib module
This based off of PR https://github.com/apache/drill/pull/258. I have
attempted to address the comments from the PR left by @cgivre
Some additional notes:
- in `STUnionAggregate.java`, there was a comment mentioning null handling,
but I'm unable to find any null handling support when defining interfaces for
aggregate functions.
- I have removed one of the failing tests from
`TestGeometryFunctions.java`. The failing tests were attempting to test
non-point geometry on functions that require it. While returning `Double.NaN`
seems appropriate for the situation, I found two issues with testing this:
1. `DefaultSequelHandler.transform()` casts the results of the
`Float8Holder` to `BigInteger` which does not have a representation for `NaN`.
As a result, this is returning a `UserException` giving a system error, which
would be the expected behaviour. However, I can't seem to test for this
exception given the test builder that is used.
2. No other tests in the file are testing for invalid geometry. This is
perhaps a larger issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChrisSandison/drill DRILL-4091
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1201
----
commit cb819d706f085cab761f4047682ff8e1086fdc57
Author: potocki <k255@...>
Date: 2015-11-16T13:05:18Z
Support for additional gis operations (relate, contains, touches, union,
get x y of a point and more)
commit a2674b3e99e79e3e32ffcb82a39b3d1956f43b13
Author: potocki <k255@...>
Date: 2015-12-03T07:51:31Z
cleaning
commit 31656350bbdc446d50fe215074c28e57afe7783d
Author: potocki <k255@...>
Date: 2016-01-18T13:27:41Z
geometry coordinates transformation using proj4j
commit 3ef4c082def3b1f088ed0afccb2cb2ffa6c44f20
Author: potocki <k255@...>
Date: 2016-01-18T13:50:03Z
ST_Distance function
commit 0e2e2d8b241f8e9d16b7d4d5d9562f58450a1670
Author: potocki <k255@...>
Date: 2016-01-19T07:39:02Z
test for srid transformation query
commit 053678b104d3427116ed8ffd3ac84ee12d28b04b
Author: potocki <k255@...>
Date: 2016-01-19T09:03:27Z
fixed style and missing file
commit 18c993096b523f8aece9cd5fac7d0c3110f3bbac
Author: potocki <k255@...>
Date: 2016-02-11T12:50:46Z
aggregate version of ST_Union function
commit 9bf8ba66570cca078e0ff6aee27c02908801a6b6
Author: potocki <k255@...>
Date: 2017-10-26T21:16:34Z
rename aggregate version of st_union to st_unionaggregate. minor
reformatting
commit 9d0ebffb3b1d00d97c225130568f381ddc826c0d
Author: potocki <k255@...>
Date: 2017-10-26T21:16:51Z
ST_Envelope, ST_X[Min|Max], ST_Y[Min|Max] geobounds functions
commit 95c0e5e01a413562b7ca4c4cfb4b4d657203d5ec
Author: potocki <k255@...>
Date: 2017-11-08T19:36:15Z
fixes in union aggregate + tests
commit fa6239c681514e8d57437c1e09cedd4715344fbc
Author: chris <chris@...>
Date: 2018-04-03T14:23:56Z
DRILL-4091: Addressed comments and fixed tests
----
---
