Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183169484
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -560,6 +554,40 @@ public void close() {
super.close();
}
+ @Override
+ protected void updateBatchMemoryManagerStats() {
+ stats.setLongStat(Metric.LEFT_INPUT_BATCH_COUNT,
batchMemoryManager.getNumIncomingBatches(LEFT_INDEX));
--- End diff --
@ppadma - The main motive of moving the metrics inside
JoinBatchMemoryManager was to avoid duplicate definition in all the
BinaryRecordBatches. I think we should improve on OperatorMetricsRegistry
rather than just overriding this method.
Or if you want you can create a new JIRA to track metrics related
improvement.
---
