Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/1235
  
    @arina-ielchiieva, the `DebugStringBuilder` class probably started as a 
wrapper around a `StringBuilder` at some point, given its name. Looks like it 
is now a wrapper around a `StringWriter`. Still, the goal of this class is to 
take a bunch of arguments and produce a string. That string can be printed, 
sent to a log, or just displayed in the debugger. (It is the debugger case that 
I was probably concerned about; some classes threw exceptions if you tried to 
examine them in the debugger.)
    
    Given that this class is a string *builder* and not a string *printer*, the 
`append()` method evokes the `append()` method in `StringBuilder`. This may be 
the point that @vrozov is making.
    
    That said, there is certainly no harm in changing the name if it helps 
people understand the purpose of the class more clearly. Since this is purely 
an internal debug class, either name is fine.


---

Reply via email to