[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

[GitBox]

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning 
for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r198886170
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java
 ##########
 @@ -19,21 +19,18 @@
 
 import org.apache.drill.common.expression.LogicalExpression;
 import org.apache.drill.common.expression.LogicalExpressionBase;
-import org.apache.drill.common.expression.SchemaPath;
 import org.apache.drill.common.expression.TypedFieldExpr;
 import org.apache.drill.common.expression.visitors.ExprVisitor;
 import org.apache.drill.exec.expr.fn.FunctionGenerationHelper;
-import org.apache.parquet.column.statistics.BooleanStatistics;
 import org.apache.parquet.column.statistics.Statistics;
 
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
-import java.util.function.BiPredicate;
+import java.util.function.BiFunction;
 
 import static 
org.apache.drill.exec.expr.stat.ParquetPredicatesHelper.hasNoNulls;
 import static 
org.apache.drill.exec.expr.stat.ParquetPredicatesHelper.isAllNulls;
-import static 
org.apache.drill.exec.expr.stat.ParquetPredicatesHelper.isNullOrEmpty;
 
 Review comment:
   Why is this change necessary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services