amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199019017
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LateralJoinPrel.java ########## @@ -104,6 +118,12 @@ private RelNode rename(RelNode input, List<RelDataTypeField> inputFields, List<S return proj; } + @Override + public RelWriter explainTerms(RelWriter pw) { + return super.explainTerms(pw).item("correlate Column: ", this.excludeCorrelateColumn ? this.getColumn() : "None"); Review comment: Will this confuse users in the sense that 'correlate column' is actually always needed for the semantics of lateral join but what excludeCorrelateColumn does is it prevents materialization of that column from the left side of the lateral. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services