chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199068099
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java
##########
@@ -32,35 +33,53 @@
import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import org.apache.drill.exec.physical.base.AbstractJoinPop;
+import org.apache.drill.exec.work.filter.RuntimeFilterDef;
+
@JsonTypeName("hash-join")
+@JsonIgnoreProperties(ignoreUnknown = true)
public class HashJoinPOP extends AbstractJoinPop {
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(HashJoinPOP.class);
+ private RuntimeFilterDef runtimeFilterDef;
Review comment:
After physical plan is generated, RuntimeFilterManager is is responsible for
constructing this runtimeFilterDef. So I guess your estimation of the cost
sending bloom filter is trivial.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
