vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199207853
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java ########## @@ -417,16 +417,9 @@ public static DateCorruptionStatus checkForCorruptDateValuesInStatistics(Parquet // column does not appear in this file, skip it continue; } - Statistics statistics = footer.getBlocks().get(rowGroupIndex).getColumns().get(colIndex).getStatistics(); - Integer max = (Integer) statistics.genericGetMax(); - if (statistics.hasNonNullValue()) { - if (max > ParquetReaderUtility.DATE_CORRUPTION_THRESHOLD) { - return DateCorruptionStatus.META_SHOWS_CORRUPTION; - } - } else { - // no statistics, go check the first page - return DateCorruptionStatus.META_UNCLEAR_TEST_VALUES; - } + IntStatistics statistics = (IntStatistics)footer.getBlocks().get(rowGroupIndex).getColumns().get(colIndex).getStatistics(); Review comment: Please see parquet format spec. `DATE` is always `int32`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services