Agirish commented on a change in pull request #1348: DRILL-6346: Create an
Official Drill Docker Container
URL: https://github.com/apache/drill/pull/1348#discussion_r199272414
##########
File path: distribution/pom.xml
##########
@@ -485,6 +485,36 @@
</plugins>
</build>
</profile>
+ <profile>
+ <!-- this profile adds/overrides few features of the 'apache-release'
+ profile in the parent pom. -->
+ <id>apache-release</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.spotify</groupId>
+ <artifactId>dockerfile-maven-plugin</artifactId>
+ <version>1.4.3</version>
+ <executions>
+ <execution>
+ <id>docker-image</id>
+ <goals>
+ <goal>build</goal>
+ <goal>push</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <repository>drill/apache-drill-centos</repository>
Review comment:
Sure. How about even simpler tag:
drill/apache-drill:1.14.0
The default tag will be for CentOS. We can have additional tags like you
mentioned:
drill/apache-drill:1.14.0-centos (alias for 1.14.0)
drill/apache-drill:1.14.0-ubuntu
drill/apache-drill:1.14.0-alpine
etc..
Also sure, the Docker Hub repo can be moved into a maven property. Should we
keep the drill docker hub repo as the default, or just make it a local
repository by default instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
