amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199354604
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -696,6 +780,18 @@ public void executeBuildPhase() throws
SchemaChangeException {
if ( cycleNum > 0 ) {
read_right_HV_vector = (IntVector)
buildBatch.getContainer().getLast();
}
+ //create runtime filter
+ if (cycleNum == 0 && enableRuntimeFilter) {
+ //create runtime filter and send out async
+ int condFieldIndex = 0;
+ for (BloomFilter bloomFilter : bloomFilters) {
+ for (int ind = 0; ind < currentRecordCount; ind++) {
+ long hashCode = hash64.hash64Code(ind, 0, condFieldIndex);
+ bloomFilter.insert(hashCode);
Review comment:
Currently, the hash join relies on memory calculations (both build and probe
sides) to do accounting for spilling purposes. The bloom filter memory use
should also be included in that calculation, although it would fine if you
create an enhancement JIRA and address it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
