sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in 
Parquet reader
URL: https://github.com/apache/drill/pull/1360#issuecomment-402282723
 
 
   @vrozov , sorry for the back & forth but I cannot read your mind because you 
give very few details with your suggestions.
   
   Sure I can handle the exception within the setSafe method; I only have one 
shot at this because I will be OOO tonight and working on another JIRA; this is 
the summary (please stop me if you don't agree):
   a) move the static checkInterrupted() method into  DrillRuntimeException
   b) move the checks into the setSafe() method
   c) setSafe will throw a DrillRuntimeException if the interrupt flag is set
   d) use the Thread.interrupted() method to clear the flag after handling

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to