weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200519816
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
##########
@@ -76,7 +77,7 @@ public boolean inScopeOf(OptionScope scope) {
}
public enum Kind {
- BOOLEAN, LONG, STRING, DOUBLE
+ BOOLEAN, LONG, STRING, DOUBLE, INTEGER
Review comment:
The reason to add an INTEGER option is that the largest BF's byte size is
supposed to be Integer.MAX_VALUE which is limited by DrillBuf's size. So
INTEGER option would be precisely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
