jbimbert commented on a change in pull request #1298: DRILL-5796: Filter
pruning for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r201399967
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/stat/ParquetFooterStatCollector.java
##########
@@ -59,7 +59,7 @@ public ParquetFooterStatCollector(ParquetMetadata footer,
int rowGroupIndex, Map
// Reasons to pass implicit columns and their values:
// 1. Differentiate implicit columns from regular non-exist columns.
Implicit columns do not
// exist in parquet metadata. Without such knowledge, implicit columns
is treated as non-exist
- // column. A condition on non-exist column would lead to canDrop =
true, which is not the
+ // column. A condition on non-exist column would lead to matches =
true, which is not the
Review comment:
ALL. Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
