sohami commented on a change in pull request #1373: DRILL-6517: Hash-Join: If
not OK, exit early from prefetchFirstBatchFromBothSides
URL: https://github.com/apache/drill/pull/1373#discussion_r201528460
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -258,6 +251,13 @@ protected boolean prefetchFirstBatchFromBothSides() {
return false;
Review comment:
`checkForEarlyFinish` checks for NONE from both side. What if only one side
receives NONE? In that case also `BatchMemoryManager.update()` should not be
called
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
