arina-ielchiieva commented on a change in pull request #1370: DRILL-5797: Use
Parquet new reader in all non-complex column queries
URL: https://github.com/apache/drill/pull/1370#discussion_r201676752
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java
##########
@@ -107,7 +105,9 @@ protected ScanBatch getBatch(ExecutorFragmentContext
context, AbstractParquetRow
ParquetReaderUtility.detectCorruptDates(footer,
rowGroupScan.getColumns(), autoCorrectCorruptDates);
logger.debug("Contains corrupt dates: {}", containsCorruptDates);
- if
(!context.getOptions().getBoolean(ExecConstants.PARQUET_NEW_RECORD_READER) &&
!isComplex(footer)) {
+ if
(!context.getOptions().getBoolean(ExecConstants.PARQUET_NEW_RECORD_READER)
+ && !ParquetReaderUtility.containsComplexColumn(footer,
rowGroupScan.getColumns())) {
+ logger.debug("Query qualifies for new Parquet reader");
Review comment:
Which query? We might add query id or something to help identification in
the log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
