sachouche commented on a change in pull request #1355: DRILL-6560: Enhanced the
batch statistics logging enablement
URL: https://github.com/apache/drill/pull/1355#discussion_r201830763
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/util/record/RecordBatchStats.java
##########
@@ -100,6 +108,119 @@ private String getQueryId(FragmentContext _context) {
}
return "NA";
}
+
+ private boolean isBatchStatsEnabledForOperator(FragmentContext context,
OperatorContext oContext) {
+ // The configuration can select what operators should log batch
statistics
+ final String statsLoggingOperator =
context.getOptions().getString(ExecConstants.STATS_LOGGING_BATCH_OPERATOR_OPTION).toUpperCase();
+ final String allOperatorsStr = "ALL";
+
+ // All operators are allowed to log batch statistics
+ if (allOperatorsStr.equals(statsLoggingOperator)) {
+ return true;
+ }
+
+ // No, only a select few are allowed; syntax:
operator-id-1,operator-id-2,..
Review comment:
- This is an internal feature; this means no need to document and invest on
user facing configuration
- QA can get the operators Id string from the CoreOperatorType class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
