ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-404696194 @vvysotskyi @arina-ielchiieva I have updated the PR. I found a few more places where methods previously expected to print to stdout, so I ended up changing more methods to make log and print versions of the methods available. Now the scope of the PR is: - **VectorUtil.showVectorAccessibleContent()** uses a logger and has been renamed to **VectorUtil.logVectorAccessibleContent()**. Additionally the missing log statement was added. - Print and log variants of methods were created for BaseTestQuery.printResult(), QueryUtils. testRunAndPrint(), QueryBuilder.print(), ClusterTest.runAndLog(), ClientFixture.runQueriesAndLog(). Log methods output to the default log appender. Print methods allow a selected few loggers to output directly to stdout allowing results to be printed to the console for debugging. Log method variants can be called from tests and left in test code. Print method variants should only be used for debugging tests and should not be committed. - LoggingResultsListener was created in addition to the PrintingResultsListener in order to enable the creation of log and print variants of all methods that output results. - PrintingUtils.java was added in order to encapsulate the code for turning on logging to stdout, so the same boilerplate is not repeated everywhere. - Added some more documentation for logging. Disallowing System.out will be done in this Jira https://issues.apache.org/jira/browse/DRILL-6464 Please let me know if you have anymore comments.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
