kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception
for failed queries submitted in WebUI
URL: https://github.com/apache/drill/pull/1379#discussion_r202257580
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
##########
@@ -83,12 +83,17 @@ public QueryResult run(final WorkManager workManager,
final WebUserConnection we
float usagePercent = getHeapUsage();
// Wait until the query execution is complete or there is error submitting
the query
- logger.debug("Wait until the query execution is complete or there is error
submitting the query");
+ if (logger.isDebugEnabled()) {
+ logger.debug("Wait until the query execution is complete or there is
error submitting the query");
+ }
do {
try {
- isComplete = webUserConnection.await(TimeUnit.SECONDS.toMillis(1));
/*periodically timeout to check heap*/
- } catch (Exception e) { }
-
+ isComplete =
webUserConnection.timedWait(TimeUnit.SECONDS.toMillis(1)); /*periodically
timeout 1sec to check heap */
Review comment:
Yep. It's sufficient to just wrap the DrillPBError into the UserException.
I'm getting the invalid schema exception reported as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
