jbimbert commented on a change in pull request #1298: DRILL-5796: Filter
pruning for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r202664099
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java
##########
@@ -124,8 +124,7 @@ private static LogicalExpression
createIsTruePredicate(LogicalExpression expr) {
*/
private static LogicalExpression createIsFalsePredicate(LogicalExpression
expr) {
return new ParquetIsPredicate<Boolean>(expr, (exprStat, evaluator) ->
- //if min value is not false or if there are all nulls -> canDrop
- isAllNulls(exprStat, evaluator.getRowCount()) ||
exprStat.hasNonNullValue() && ((BooleanStatistics) exprStat).getMin()
+ exprStat.hasNonNullValue() && ((BooleanStatistics) exprStat).getMin() ||
isAllNulls(exprStat, evaluator.getRowCount()) ? RowsMatch.NONE :
checkNull(exprStat)
Review comment:
@vrozov java-exec/src/test/resources/parquetFilterPush/blnTbl/0_0_3.parquet
gives ST:[num_nulls: 3, min/max not defined] whihc means hasNonNullValue=false
but isAllNulls=true, which is what we are looking for. This happens each time
we run
testBooleanPredicate()
@arina-ielchiieva isallNulls would produce incorrect values if getNumNulls
is undefined, which may happen whatever the return value of hasNonNullValue
(see stats of parquet file 0_0_3.parquet). Would it be possible that all the
stats (num_nulls, min and max) are not defined for ParquetIsPredicate entering
file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
