paul-rogers commented on issue #1367: DRILL-6585: PartitionSender clones 
vectors, but shares field metdata
URL: https://github.com/apache/drill/pull/1367#issuecomment-405457988
 
 
   @sohami, the problem is simply that each value vector can stand alone: the 
`values` vector is, itself, a perfectly valid vector. However, the 
`MaterializedField` metadata for the `values` vector is inconsistent with the 
vector class. I considered this a bug. But, given the hassle with this PR, we 
may want to declare that inconsistency a feature.
   
   In the result set loader code, I tried to use the vector metadata to 
recursively manage vectors: a required int vector (say) was to be handled the 
same whether it is a "top-level" or nested `values` vector. The result was 
nice, simple code.
   
   I will instead revise the code use the class of the vector as accurate 
metadata, and not rely on the unreliable metadata. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to