vrozov commented on a change in pull request #1383: DRILL-6613: Refactor
MaterializedField
URL: https://github.com/apache/drill/pull/1383#discussion_r203416278
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java
##########
@@ -38,6 +41,8 @@
*/
public class MaterializedField {
+ public final static MaterializedField OFFSETS_FIELD = new
MaterializedField(ValueVector.OFFSETS_VECTOR_NAME,
Types.required(MinorType.UINT4), 0);
Review comment:
I disagree. I don't see any problem with static `OFFSET_FIELD` belonging to
`MaterializedField`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
