parthchandra commented on a change in pull request #1333: DRILL-6410: Memory
leak in Parquet Reader during cancellation
URL: https://github.com/apache/drill/pull/1333#discussion_r203207677
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
##########
@@ -83,21 +80,18 @@
class AsyncPageReader extends PageReader {
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(AsyncPageReader.class);
- private ExecutorService threadPool;
- private long queueSize;
- private LinkedBlockingQueue<ReadStatus> pageQueue;
- private ConcurrentLinkedQueue<Future<Void>> asyncPageRead;
- private long totalPageValuesRead = 0;
- private Object pageQueueSyncronize = new Object(); // Object to use to
synchronize access to the page Queue.
- // FindBugs complains if
we synchronize on a Concurrent Queue
+ private final ExecutableTasksLatch<AsyncPageReaderTask> executableTasksLatch;
Review comment:
The documentation would be useful for the reviewer too. It is easier to
check the code if one knows what what guarantees ExecutableTasksLatch is
supposed to provide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
