arina-ielchiieva commented on a change in pull request #1387: DRILL-6603: Set
num_nulls for parquet statistics to -1 when actual number is not defined.
URL: https://github.com/apache/drill/pull/1387#discussion_r203801896
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/metadata/MetadataBase.java
##########
@@ -108,6 +105,18 @@
public static abstract class ColumnMetadata {
+
+ /**
+ * Number of nulls is considered to be valid if its value is not null and
-1.
+ *
+ * @return true if nulls value is defined, false otherwise
+ */
+ @JsonIgnore
+ public boolean isNullsDefined() {
+ Long nulls = getNulls();
Review comment:
I know and totally agree that `long` usage is more correct choice here but
this was done before and I left `Long` for backward compatibility plus did not
want to change all `ColumnMetadata` successors yo avoid any problems with
deserialization. I think we can make this changes in subsequent Jira
DRILL-6620, added comment in Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
