vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning
for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r204817724
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetPushDownFilter.java
##########
@@ -165,12 +167,29 @@ protected void doOnMatch(RelOptRuleCall call, FilterPrel
filter, ProjectPrel pro
return;
}
-
RelNode newScan = ScanPrel.create(scan, scan.getTraitSet(), newGroupScan,
scan.getRowType());;
if (project != null) {
newScan = project.copy(project.getTraitSet(), ImmutableList.of(newScan));
}
+
+ if (newGroupScan instanceof AbstractParquetGroupScan) {
+ RowsMatch matchAll = RowsMatch.ALL;
+ List<RowGroupInfo> rowGroupInfos = ((AbstractParquetGroupScan)
newGroupScan).rowGroupInfos;
+ for (RowGroupInfo rowGroup : rowGroupInfos) {
+ if (rowGroup.getRowsMatch() != RowsMatch.ALL) {
+ matchAll = RowsMatch.SOME;
+ break;
+ }
+ }
+ if (matchAll == ParquetFilterPredicate.RowsMatch.ALL) {
+ call.transformTo(newScan);
+ }
+ } else {
+ final RelNode newFilter = filter.copy(filter.getTraitSet(),
ImmutableList.<RelNode>of(newScan));
+ call.transformTo(newFilter);
+ }
+
final RelNode newFilter = filter.copy(filter.getTraitSet(),
ImmutableList.<RelNode>of(newScan));
Review comment:
How it works in case `newGroupScan` is not an instance of
`AbstractParquetGroupScan`? Will not `filter.copy` be called twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
