sohami commented on a change in pull request #1344: DRILL-6461: Added basic
data correctness tests for hash agg, and improved operator unit testing
framework.
URL: https://github.com/apache/drill/pull/1344#discussion_r209677503
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetBatch.java
##########
@@ -29,13 +30,28 @@
import org.apache.drill.exec.record.selection.SelectionVector2;
import org.apache.drill.exec.record.selection.SelectionVector4;
+import java.util.ArrayList;
import java.util.Iterator;
+import java.util.List;
-public class RowSetBatch implements RecordBatch {
- private final RowSet rowSet;
+/**
+ * A mock operator that returns the provided {@link RowSet}s as batches.
Currently it's assumed that all the {@link RowSet}s have the same schema.
+ */
+public class RowSetBatch implements CloseableRecordBatch {
Review comment:
If you want you can leave it as is for now. I can take a look on how to
refactor MockRecordBatch class along with other tests which uses it, which I
have to do anyways. I was also thinking of making it use RowSets instead of
container.
The reason for creating separate class was to use it specifically for
testing different IterOutcomes in context of Lateral&Unnest only whereas
RowSetBatch looked more of a very simple implementation to just hold one
container. Was not sure if MockRecordBatch will play well with other operators
in general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
