kkhatua commented on a change in pull request #1279: DRILL-5735: Allow
search/sort in the Options webUI
URL: https://github.com/apache/drill/pull/1279#discussion_r210044779
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ExtendedOptionIterator.java
##########
@@ -116,14 +146,16 @@ public boolean hasNext() {
@Override
public ExtendedOptionValueWrapper next() {
final OptionValue value = mergedOptions.next();
- final HashMap<OptionValue.Kind,String> typeMapping = new HashMap() {{
- put(Kind.STRING,"VARCHAR");
- put(Kind.DOUBLE,"FLOAT");
- put(Kind.LONG,"BIGINT");
- put(Kind.BOOLEAN,"BIT");
- }};
- return new ExtendedOptionValueWrapper(value.name,
typeMapping.get(value.kind),
value.accessibleScopes,value.getValue().toString(), value.scope);
+ final Status status;
+ if (value.accessibleScopes == AccessibleScopes.BOOT) {
+ status = Status.BOOT;
+ } else {
+ final OptionValue def = fragmentOptions.getDefault(value.name);
+ status = (value.equalsIgnoreType(def) ? Status.DEFAULT : Status.CHANGED
);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
