sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r210030287
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/RuntimeFilterPrel.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.planner.physical; + +import org.apache.calcite.plan.RelOptCluster; +import org.apache.calcite.plan.RelTraitSet; +import org.apache.calcite.rel.RelNode; +import org.apache.drill.exec.physical.base.PhysicalOperator; +import org.apache.drill.exec.physical.config.RuntimeFilterPOP; +import org.apache.drill.exec.record.BatchSchema.SelectionVectorMode; + +import java.io.IOException; +import java.util.List; + +public class RuntimeFilterPrel extends SinglePrel{ + static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(RuntimeFilterPrel.class); + + public RuntimeFilterPrel(Prel child){ + super(child.getCluster(), child.getTraitSet(), child); + } + + public RuntimeFilterPrel(RelOptCluster cluster, RelTraitSet traits, RelNode child) { + super(cluster, traits, child); + } + + @Override + public RelNode copy(RelTraitSet traitSet, List<RelNode> inputs) { + return new RuntimeFilterPrel(this.getCluster(), traitSet, inputs.get(0)); + } + + @Override + public PhysicalOperator getPhysicalOperator(PhysicalPlanCreator creator) throws IOException { + RuntimeFilterPOP r = new RuntimeFilterPOP( ((Prel)getInput()).getPhysicalOperator(creator)); + return creator.addMetadata(this, r); + } + + @Override + public SelectionVectorMode getEncoding() { + return SelectionVectorMode.TWO_BYTE; + } + + @Override + public Prel prepareForLateralUnnestPipeline(List<RelNode> children) { + return (Prel) this.copy(this.traitSet, children); Review comment: Now since you have changed the logic to only include `RuntimeFilter` operator on top of probe side Scan this `prepareForLateralUnnestPipeline` method should not be overriden in this Prel. RuntimeFilter should not appear on right side of lateral/unnest plan since Joins are not supported within that subquery as of now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
