Ben-Zvi commented on a change in pull request #1409: DRILL-6644: Don't reserve
space for incoming probe batches unnecessarily during the build phase.
URL: https://github.com/apache/drill/pull/1409#discussion_r210144994
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java
##########
@@ -379,7 +379,7 @@ public void testLeftHashJoinLeftEmpty() throws Exception {
.build();
RecordBatch joinBatch = new PopBuilder()
- .physicalOperator(new HashJoinPOP(null, null,
Lists.newArrayList(joinCond("a", "EQUALS", "a2")), JoinRelType.LEFT))
+ .physicalOperator(new HashJoinPOP(null, null,
Lists.newArrayList(joinCond("a2", "EQUALS", "a")), JoinRelType.LEFT))
Review comment:
Good catch .... so it took the calculator to fail to note that the columns
were mismatched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
