sohami commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-413248827 @weijietong - Would have been easier to just cherry-pick the commits on top of your rebased branch. But I guess it's fine. `recordCount` is not the actual record count, its the selected number of records. I have also added comments to differentiate between the two variables. Few things to resolve: 1) Since I have already shared a commit with generated protobuf files for c++ client. It would be good to take that as well. 2) Please resolve the travis build failure. 3) Meanwhile I ran tests on my shared branch yesterday and there are unit tests failures. Can you run unit tests locally and make sure all of them are passing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
