Hi all, I'm working on the PR-1397 <https://github.com/apache/drill/pull/1397> for DRILL-6633, which aims to replace usage of Guava classes by JDK ones where possible.
One of the things I have done was replacing Preconditions.checkNotNull() by Objects.requireNonNull(). I have a discussion in this PR with Vlad Rozov about the replacement mentioned above (see our arguments in these comments <https://github.com/apache/drill/pull/1397#discussion_r207266884>). So I'm wondering the opinion of the community regarding the way which should be chosen for further development: - Should all usages of Preconditions.checkNotNull() be replaced by Objects.requireNonNull() and Preconditions.checkNotNull() banned? - Should be left Preconditions.checkNotNull() and allowed usage of both Preconditions.checkNotNull() and Objects.requireNonNull(). Kind regards, Volodymyr Vysotskyi
