gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite
version to 1.17.0
URL: https://github.com/apache/drill/pull/1425#discussion_r212091811
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java
##########
@@ -419,279 +395,161 @@ public TimeZone getTimeZone() {
// No isWrapperFor(Class<?>) (it doesn't throw SQLException if already
closed).
// No unwrap(Class<T>) (it doesn't throw SQLException if already closed).
- @Override
- public AvaticaStatement createStatement() throws SQLException {
- throwIfClosed();
- return super.createStatement();
- }
-
- @Override
Review comment:
We seem to have removed a lot of overridden functions here and below. Could
you please explain why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
