vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update
Calcite version to 1.17.0
URL: https://github.com/apache/drill/pull/1425#discussion_r212235501
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java
##########
@@ -65,107 +65,52 @@ private void throwIfClosed() throws
AlreadyClosedSqlException {
// called ResultSet.)
@Override
- public DrillConnectionImpl getConnection() {
- // Can't throw any SQLException because AvaticaConnection's
getConnection() is
- // missing "throws SQLException".
- try {
- throwIfClosed();
- } catch (AlreadyClosedSqlException e) {
- throw new RuntimeException(e.getMessage(), e);
- }
+ public DrillConnectionImpl getConnection() throws SQLException {
+ checkOpen();
return connection;
}
- // WORKAROUND: Work around AvaticaStatement's code that wraps _any_
exception,
- // even if SQLException, by unwrapping to get cause exception so caller can
- // throw it directly if it's a SQLException:
- // TODO: Any ideas for a better name?
- private SQLException unwrapIfExtra( final SQLException superMethodException
) {
Review comment:
Exactly this method is not required since now we don't wrap `SQLException`
exceptions into `SQLException`. Regarding other methods, as I mentioned in the
previous comment, parent methods in Avatica have a check for connection is
open, so it is excessive to left them in Drill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
