vrozov commented on a change in pull request #1437: DRILL-6702: Disable CPU
Reporting for non-HotSpot JDKs
URL: https://github.com/apache/drill/pull/1437#discussion_r212421817
##########
File path: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java
##########
@@ -32,13 +32,20 @@
*/
@SuppressWarnings("restriction")
public class CpuGaugeSet implements MetricSet {
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(CpuGaugeSet.class);
- private OperatingSystemMXBean osMXBean;
- private RuntimeMXBean rtMXBean;
+ private final OperatingSystemMXBean osMXBean;
+ private final RuntimeMXBean rtMXBean;
public CpuGaugeSet() {
- this.osMXBean = (OperatingSystemMXBean)
ManagementFactory.getOperatingSystemMXBean();
this.rtMXBean = ManagementFactory.getRuntimeMXBean();
+ //DRILL-6702: Instead of worrying about compiling with IBM JDK, for now,
we shall provide no CPU metrics for non-HotSpot JVMs
+ if (System.getProperty("java.vm.name").contains("HotSpot")) {
Review comment:
- It is a common design pattern in the case when a check will result in a
positive outcome 99.9% of the time.
- it can handle a JDK that decides not to implement
`ManagementFactory.getOperatingSystemMXBean()` and throw
`UnsupportedOperationException` instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
