sohami commented on a change in pull request #1296: DRILL-5365: Prevent plugin
config from changing default fs. Make DrillFileSystem Immutable.
URL: https://github.com/apache/drill/pull/1296#discussion_r213508890
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/DrillFileSystem.java
##########
@@ -79,32 +77,56 @@
private final ConcurrentMap<DrillFSDataInputStream, DebugStackTrace>
openedFiles = Maps.newConcurrentMap();
+ private final Configuration fsConf;
private final FileSystem underlyingFs;
private final OperatorStats operatorStats;
private final CompressionCodecFactory codecFactory;
+ private boolean initialized = false;
+
public DrillFileSystem(Configuration fsConf) throws IOException {
this(fsConf, null);
}
public DrillFileSystem(Configuration fsConf, OperatorStats operatorStats)
throws IOException {
- this.underlyingFs = FileSystem.get(fsConf);
- this.codecFactory = new CompressionCodecFactory(fsConf);
+ // Configuration objects are mutable, and the underlying FileSystem object
may directly use a passed in Configuration.
+ // In order to avoid scenarios where a Configuration can change after a
DrillFileSystem is created, we make a copy
+ // of the Configuration.
+ this.fsConf = new Configuration(fsConf);
Review comment:
We can convert `this.fsConf` to be a local variable and in `getConf()` do
`return new Configuration(underlyingFs.getConf());`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
