amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r219033777
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DrillDistributionTraitDef.java
##########
@@ -86,7 +86,10 @@ public RelNode convert(
return new HashToRandomExchangePrel(rel.getCluster(),
planner.emptyTraitSet().plus(Prel.DRILL_PHYSICAL).plus(toDist), rel,
toDist.getFields());
case RANGE_DISTRIBUTED:
- return new OrderedPartitionExchangePrel(rel.getCluster(),
planner.emptyTraitSet().plus(Prel.DRILL_PHYSICAL).plus(toDist), rel);
+ // return new OrderedPartitionExchangePrel(rel.getCluster(),
planner.emptyTraitSet().plus(Prel.DRILL_PHYSICAL).plus(toDist), rel);
Review comment:
The OrderedPartitionExchange was not being used anywhere. Its original
purpose was to do range-based sorting; however this was not completely
functional. It was also a much more complex operator (see its implementation
in OrderedPartitionRecordBatch). I think if we go back to fixing it and using
it in future, we will probably add a new type of distribution trait. I will
add explanation along these lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
