vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator 
context to logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#discussion_r219225796
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
 ##########
 @@ -125,17 +126,24 @@ public void receivingFragmentFinished(final 
FragmentHandle handle) {
 
   @Override
   public void dumpOperators() {
-    if (!operators.isEmpty()) {
-      logger.info("Operator dump started.");
-      for (CloseableRecordBatch batch : operators) {
-        batch.dump();
-        if (batch.isFailed()) {
-          // No need to proceed further as this batch is the one that failed
-          return;
+    final int numberOfOperatorsToDump = 2;
 
 Review comment:
   I've meant dumping info for last two batches, not operators. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to