sachouche commented on a change in pull request #1470: DRILL-6746: Query can 
hang when PartitionSender task thread sees a co…
URL: https://github.com/apache/drill/pull/1470#discussion_r219618697
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.java
 ##########
 @@ -63,6 +64,15 @@ public RawFragmentBatch take() throws IOException, 
InterruptedException {
       return batch;
     }
 
+    @Override
+    public RawFragmentBatch poll(long timeout, TimeUnit timeUnit) throws 
InterruptedException, IOException {
+      RawFragmentBatch batch = buffer.poll(timeout, timeUnit);
 
 Review comment:
   Does poll return null when timeout is reached? if not, then you should 
handle timeout exception. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to