KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r219863225
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java ########## @@ -47,7 +47,8 @@ protected final boolean unionTypeEnabled; protected BatchState state; - // In case of Exception will be IterOutcome.STOP + // Used for state dump + protected boolean failed; Review comment: The `state` is converted to `lastOutcome` in `next()` which represents last outcome of `next()` invocation and `failed` represents if there was an `Exception` thrown during `next()` execution. But you are right that there are unnecessary settings of `failed` and `lastOutcome` fields, so moved managing of the fields of child classes to the class only. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
