vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator
context to logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#discussion_r220518550
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
##########
@@ -123,6 +124,28 @@ public void receivingFragmentFinished(final
FragmentHandle handle) {
logger.warn("Currently not handling FinishedFragment message");
}
+ @Override
+ public void dumpOperators() {
+ final int numberOfBatchesToDump = 2;
+ logger.error("Operator dump started: dumping last {} failed batches",
numberOfBatchesToDump);
Review comment:
I am confused. Do we dump operators or batches? From your last comments it
seems you named wrongly the object of dumping. Do we need to rename them here
too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
