sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs
aggregating work from the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#discussion_r219938720
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterWritable.java
##########
@@ -81,6 +82,37 @@ public void aggregate(RuntimeFilterWritable
runtimeFilterWritable) {
}
}
+ public RuntimeFilterWritable duplicate(BufferAllocator bufferAllocator) {
+ int len = data.length;
+ DrillBuf[] cloned = new DrillBuf[len];
+ int i = 0;
+ for (DrillBuf src : data) {
+ int capacity = src.readableBytes();
+ DrillBuf duplicateOne = bufferAllocator.buffer(capacity);
+ int readerIndex = src.readerIndex();
+ src.readBytes(duplicateOne, 0, capacity);
Review comment:
consider using `duplicateOne.writeBytes(src)` instead of
`src.readBytes(duplicateOne, 0, capacity)` since that will update the index of
`duplicateOne` correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
