vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r222607432
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ValueVectorHashHelper.java
##########
@@ -72,6 +73,7 @@ public Hash64 getHash64(LogicalExpression[] hashFieldsExp,
TypedFieldId[] hashFi
ClassGenerator<Hash64> cg = codeGenerator.getRoot();
setupBuild64Hash(cg, GetHashIncomingBuildColMapping, recordBatch,
hashFieldsExp, hashFieldIds);
Hash64 hash64 = context.getImplementationClass(codeGenerator);
+ CodeGenMemberInjector.injectMembers(cg, hash64, context);
Review comment:
This method call should be added to every place where
`context.getImplementationClass()` method is called. It would be good to move
`injectMembers` inside of `getImplementationClass()` if it is possible or
somehow combine them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
