vvysotskyi commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222759782
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
##########
@@ -127,6 +135,18 @@ public static boolean checkCartesianJoin(RelNode relNode,
List<Integer> leftKeys
return false;
}
+ /**
+ * Overloaded version of {@link JoinUtils#checkCartesianJoin(RelNode, List,
List, List)}
Review comment:
Please change the Javadoc to reflect the aim of this method. (just copy it
from the overloaded method)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
