ihuzenko commented on a change in pull request #1488: DRILL-786: Allow CROSS
JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r222932584
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
##########
@@ -256,14 +255,6 @@ public SqlNode visit(SqlCall sqlCall) {
"See Apache Drill JIRA: DRILL-1986");
throw new UnsupportedOperationException();
}
-
- // Block Cross Join
- if(join.getJoinType() == JoinType.CROSS) {
Review comment:
Yes, at this moment we can detect that it's explicit cross join because here
inspected object is SqlNode, but later after conversion to RelNode this
`JoinType.CROSS` will be lost, instead we only have `JoinRelType.INNER` in the
node. So to preserve original type additional tricks with query context are
necessary.
What you suggest is actually **Option 2** from my comment in
[DRILL-786](https://issues.apache.org/jira/browse/DRILL-786) , but as I
remember we agreed to go with **Option 3** . So what are the reasons to move
back and use Option 2 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
