vvysotskyi commented on a change in pull request #1503: DRILL-6795: Upgrade 
Janino compiler from 2.7.6 to 3.0.9
URL: https://github.com/apache/drill/pull/1503#discussion_r225586948
 
 

 ##########
 File path: exec/java-exec/pom.xml
 ##########
 @@ -349,6 +349,14 @@
       <artifactId>joda-time</artifactId>
       <version>2.9</version>
     </dependency>
+    <dependency>
 
 Review comment:
   Currently, Drill has only transitive dependencies to `janino` and 
`commons-compiler`, but their classes are used in Drill code, so specified 
direct dependencies to avoid relying on transitive ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to