amansinha100 commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-430517349 The formatting of the message is still incorrect. Also, I ran some test queries and found an issue. After I set the `enable_nljoin_for_scalar_only` flag to false and set the `slice_target` to a small number (to simulate joining slightly bigger tables), the cross join planning still fails. This could be a pre-existing issue but since now we are explicitly supporting cross join, can you check why the query fails. 0: jdbc:drill:zk=local> alter session set `planner.enable_nljoin_for_scalar_only` = false; +-------+-------------------------------------------------+ | ok | summary | +-------+-------------------------------------------------+ | true | planner.enable_nljoin_for_scalar_only updated. | +-------+-------------------------------------------------+ 0: jdbc:drill:zk=local> alter session set `planner.slice_target` = 1; +-------+--------------------------------+ | ok | summary | +-------+--------------------------------+ | true | planner.slice_target updated. | +-------+--------------------------------+ 0: jdbc:drill:zk=local> explain plan for select count(*) from cp.`tpch/nation.parquet` cross join cp.`tpch/region.parquet`; Error: UNSUPPORTED_OPERATION ERROR: This query cannot be planned possibly due to either a cartesian join or an inequality join. If a cartesian or inequality join is used intentionally, set the option 'planner.enable_nljoin_for_scalar_only' to false and try again.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
