amansinha100 commented on a change in pull request #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#discussion_r226056318
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java ########## @@ -65,6 +68,11 @@ } private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(JoinUtils.class); + public static final String FAILED_TO_PLAN_CARTESIAN_JOIN = String.format( + "This query cannot be planned possibly due to either a cartesian join or an inequality join. %n" + Review comment: Hi @ihuzenko , have you tested on Sqlline ? (not just through unit tests). On my MacBook this is how it displays (all one line): Error: UNSUPPORTED_OPERATION ERROR: This query cannot be planned possibly due to either a cartesian join or an inequality join. If a cartesian or inequality join is used intentionally, set the option 'planner.enable_nljoin_for_scalar_only' to false and try again. BTW, can you check the other comment I had provided..we would need to fix that issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
