arina-ielchiieva commented on a change in pull request #1509: DRILL-6810:
Disable NULL_IF_NULL NullHandling for functions with Comp…
URL: https://github.com/apache/drill/pull/1509#discussion_r227331483
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java
##########
@@ -65,7 +65,12 @@ public DrillAggFuncHolder(
FunctionAttributes attributes,
FunctionInitializer initializer) {
super(attributes, initializer);
- checkArgument(attributes.getNullHandling() == NullHandling.INTERNAL, "An
aggregation function is required to do its own null handling.");
+ }
+
+ @Override
+ protected void checkNullHandling(NullHandling nullHandling) {
Review comment:
1. Please move under public methods here and in another class.
2. Please update the message -> "... null handling strategy"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
