sohami commented on a change in pull request #1504: DRILL-6792: Find the right
probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504#discussion_r229501155
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java
##########
@@ -379,11 +379,16 @@ public FragmentExecutor getFragmentRunner(final
FragmentHandle handle) {
return runningFragments.get(handle);
}
+ /**
+ * receive the RuntimeFilter thorough the wire
+ * @param runtimeFilter
+ */
public void receiveRuntimeFilter(final RuntimeFilterWritable
runtimeFilter) {
BitData.RuntimeFilterBDef runtimeFilterDef =
runtimeFilter.getRuntimeFilterBDef();
boolean toForeman = runtimeFilterDef.getToForeman();
QueryId queryId = runtimeFilterDef.getQueryId();
String queryIdStr = QueryIdHelper.getQueryId(queryId);
+ runtimeFilter.retainBuffers(1);
Review comment:
I looked into the code. It's weird that you are seeing data tunnel being
hanged while sending runtimeFilter since for runtime filter it doesn't look
like we are using throttling listener based on semaphore count. If ACK is not
received the DataTunnel shouldn't hang while sending RuntimeFilter. It will
only hang while sending the DataBatches.
DataTunnel is created here for sending RuntimeFilter:
https://github.com/apache/drill/pull/1504/files#diff-86eb65fdf93f77f95838f885752e660cR191
In `tunnel.sendRuntimeFilter` I don't see anywhere `semaphore.acquire` is
called which will result in hang if Ack is not received.
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java#L94
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
